[mohamede1945]

Problem

When another collection already had the name (trimmed, case-insensitive), addCollection returned that collection, while updateCollection threw DuplicateCollectionNameException. Apps couldn't tell a create from a no-op. On iOS, creating "Study" when "Study" existed closed the name alert with no feedback. quran/quran-ios#1272 works around this by checking the collection IDs before creating, and that check leaves a small race.

Change

• CollectionsRepositoryImpl.addCollection: inside the insert transaction, throws DuplicateCollectionNameException(existing.name) when store.byName finds a row. The checks run in the same order as updateCollection: reserved name, then length, then duplicate.
• QuranDataService.addCollection: no code change. mutatingCall rethrows before triggerSync, so a rejected add starts no sync, and isRejection() already logs this exception at info.
• The KDoc on CollectionsRepository and QuranDataService now lists the exception for add, and for update on the interface, which lacked it.
• No internal path relied on the old behaviour: the import merger and highlight collections write through CollectionStore directly, and sync and remote apply go through CollectionsType.

Tests

• CollectionNameUniquenessTest: adding a case or whitespace variant now throws with the stored name, and only one row stays.
• TextScenariosTest TXT-08 and TXT-10: the second add now throws. TXT-08 still checks that the next sync posts nothing. TXT-10 still proves the leading BOM matches the same key, and it now also checks that the ideographic space is trimmed.
• QuranDataServiceWriteLoggingTest: a new test checks that adding a taken name logs at info and triggers no sync.
• ./gradlew jvmTest testAndroidHostTest --continue: passes.
• The mobile-sync-spm integration tests pass against an XCFramework built from this branch.
• quran-ios AnnotationsServiceTests and BookmarksFeatureTests pass in local-sync mode.
• I didn't run iosSimulatorArm64Test / macosArm64Test locally.

Consumers

• mobile-sync-spm: the companion PR updates the docs and adds an integration test. It needs the release that includes this change.
• quran_android:
  • Already handled: the add-collection and add-tag flows map this exception to CollectionNameException.Duplicate.
  • Behaviour change: a case or whitespace variant used to quietly return the existing tag or collection. It now shows the duplicate-name error.
  • Breaks on upgrade: BookmarksDaoImplCollectionRulesTest "adding a tag whose name is taken returns the existing tag" uses the real repository, so it will need updating.

🤖 Generated with Claude Code