fix: quarto render template.qmd failure - #44
Open
mcanouil wants to merge 2 commits into
Open
Conversation
Emit \Description inside Quarto's figure instead of a nested figure environment (caused "Not in outer par mode"), and set biblio-style to ACM-Reference-Format instead of te.bst (bibtex looked for te.bst.bst).
te.bst is a Theoretical Economics style left over from the forked template; the ACM style is ACM-Reference-Format, which the extension ships and add-bibliography.lua already selects.
Collaborator
|
Thanks! If we're reviving this format officially (which is good!) we should probably add some tests to verify that our output sufficiently matches that of the pure-latex ACM template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendering
template.qmdfailed; fixes:fancy-figure.luawrapped images in a nestedfigureenvironment ("Not in outer par mode") — now emits\Descriptioninside Quarto's own figure.biblio-stylewaste.bst, so bibtex looked for the non-existentte.bst.bst— set toACM-Reference-Format.te.bst(a Theoretical Economics style from the forked template).Found while running the release checks in my extensions directory (https://github.com/mcanouil/quarto-extensions/blob/quarto-tests/logs/quarto-journals/acm/release/1.9.38/stderr.log).