fix: pass all failing tests in utility library#231
Open
stooit wants to merge 1 commit into
Open
Conversation
…ests - calculator: divide now throws on division by zero - string-utils: wordCount handles consecutive spaces; truncate implemented with word-boundary cut and ellipsis accounting - task-manager: implement remove, update, and sortBy (priority/createdAt) - validator: isEmail accepts long TLDs; isUrl accepts URLs with ports - date-utils: fix formatRelative rounding (off-by-one + 24h boundary)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across 5 source files. The full suite now passes: 60 pass / 0 fail. No test files were modified and no dependencies were added.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")instead of returningInfinity.src/string-utils.ts—wordCountsplits on/\s+/to handle consecutive spaces;truncateimplemented (returns input when within limit, otherwise cuts at the last word boundary with the ellipsis counted towardmaxLength, and handles strings shorter than the ellipsis).src/task-manager.ts— implemented the missingremove,update, andsortBymethods (sortByorders priority high→medium→low andcreatedAtoldest-first;remove/updatereturnfalsefor unknown ids).src/validator.ts—isEmailnow accepts long TLDs (e.g.user@example.museum);isUrlaccepts URLs with ports (e.g.http://localhost:3000).src/date-utils.ts— fixedformatRelativerounding so 36h reads "2 days ago" and the hours branch usesMath.floor, so it can never emit "24 hours ago".Testing
bun test→ 60 pass, 0 fail, 70 expect() calls.Assumptions
Math.floor24h-boundary guard informatRelative) surfaced during review; it changes no tested behaviour.🤖 Generated autonomously.