fix: implement missing utilities and fix edge-case bugs#228
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide() now throws on division by zero - string-utils: fix wordCount whitespace handling, implement truncate - task-manager: complete missing/incomplete TaskManager methods - date-utils: fix formatRelative off-by-one and rounding boundary - validator: fix isUrl to accept ports and other edge cases All 60 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the utility library. 60/60 tests now pass, 0 failures. No test files modified, no dependencies added.
Changes
src/calculator.tsdivide()now throwsError("Division by zero")instead of returningInfinitysrc/string-utils.tswordCount()splits on\s+to handle consecutive whitespace;truncate()implemented (trims to word boundary)src/task-manager.tsTaskManagermethods to match test expectationssrc/date-utils.tsformatRelativeoff-by-one (floor vs round) and made the hours/days rounding boundary consistent so "24 hours ago" can never displaysrc/validator.tsisUrl()now accepts URLs with ports (e.g.http://localhost:3000) and other edge casesVerification
bun test-> 60 pass / 0 failformatRelativeAssumptions