fix: make all tests pass (calculator, string-utils, task-manager, date-utils, validator)#227
Open
stooit wants to merge 1 commit into
Open
fix: make all tests pass (calculator, string-utils, task-manager, date-utils, validator)#227stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
…ests - calculator: throw on division by zero - string-utils: fix wordCount whitespace handling, implement truncate - task-manager: complete missing/incomplete methods - date-utils: fix off-by-one in relative time (floor vs round) - validator: accept URLs with port in isUrl All 60 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the utility library. The full suite now passes: 60 passing / 0 failing. No test files were modified and no dependencies were added.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")when the divisor is0.src/string-utils.ts—wordCountnow trims and splits on\s+so runs of whitespace don't create empty tokens;truncateimplemented to append whole words up to the limit.src/task-manager.ts— completed missing/incompleteTaskManagermethods to match expected behaviour.src/date-utils.ts— fixed an off-by-one in relative-time formatting (useMath.floorrather thanMath.round).src/validator.ts—isUrlnow accepts URLs with an explicit port (e.g.http://localhost:3000).Verification
bun test→ 60 pass, 0 fail, 70 expect() calls across 5 files.Assumptions
🤖 Generated autonomously.