fix: repair all failing utility-library tests#225
Open
stooit wants to merge 1 commit into
Open
Conversation
…validator utils - calculator: divide() now throws on division by zero - string-utils: implement truncate() and fix wordCount() whitespace handling - task-manager: implement missing remove/update/sortBy methods - date-utils: fix formatRelative off-by-one (Math.round day boundaries) - validator: isEmail accepts long TLDs; isUrl accepts URLs with ports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously failing tests across the utility library. The suite now reports 60 pass, 0 fail with no previously-passing test broken.
Changes by file
src/calculator.ts—divide()now throwsError("Division by zero")when the divisor is0(was returningInfinity).src/string-utils.ts— implementedtruncate(); fixedwordCount()to split on/\s+/so consecutive whitespace no longer inflates the count.src/task-manager.ts— implemented the missing/incompleteremove,update, andsortBymethods.src/date-utils.ts— fixed the off-by-one informatRelativeby rounding day boundaries (Math.round), so e.g. 36 hours → "2 days ago".src/validator.ts—isEmailnow accepts long TLDs (e.g..museum);isUrlnow accepts URLs with ports (e.g.http://localhost:3000).BUG:JSDoc comments that described already-fixed behaviour.Verification
bun test→ 60 pass, 0 fail (70 expect() calls).date-utilsrounding behaviour matches the documented contract (36h → "2 days ago").Assumptions