fix: resolve all failing tests in utility library#224
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero - date-utils: fix off-by-one in formatRelative (round vs floor) - string-utils: implement truncate word-boundary/ellipsis logic and fix wordCount - task-manager: implement remove, update, and sortBy methods - validator: fix isEmail long-TLD/subdomain and isUrl port handling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across 5 source files in the TypeScript utility library. All 60 tests now pass (previously 44 pass / 16 fail). No test files were modified and no dependencies were added.
Changes by file
src/calculator.ts—dividenow throws"Division by zero"instead of silently returningInfinity.src/date-utils.ts— fixed off-by-one informatRelative: usesMath.roundfor day calculation so 36 hours ago correctly renders as "2 days ago".src/string-utils.ts— implementedtruncate(word-boundary truncation, ellipsis counting towardmaxLength, handling strings shorter than the ellipsis, and returning unchanged when within limit); fixedwordCountto collapse multiple consecutive spaces.src/task-manager.ts— implemented missingremove,update, andsortBy(priority andcreatedAtordering) methods.src/validator.ts— fixedisEmailto accept long TLDs and subdomains; rewroteisUrlusing theURLconstructor so URLs with ports (e.g.http://localhost:3000) validate correctly.Verification
bun test→ 60 pass, 0 failAssumptions
dividebehaviour on zero is to throw (consistent with the test expecting an error).formatRelativeuses round-half semantics for the hours/days boundary, consistent with the 36h → "2 days ago" test.