fix: make all failing tests pass across utility library#223
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero - string-utils: wordCount handles consecutive whitespace; truncate implemented with word-boundary + ellipsis budget - task-manager: implement remove, update, and sortBy (priority/createdAt/status) - date-utils: formatRelative uses Math.round to fix day off-by-one - validator: isEmail accepts long TLDs; isUrl accepts URLs with a port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously failing tests across the 5 utility modules. The full suite now passes: 60 pass / 0 fail. No test files modified, no dependencies added.
Changes
src/calculator.tsdividethrowsError("Division by zero")instead of returningInfinitysrc/string-utils.tswordCountsplits on/\s+/to handle consecutive whitespace;truncateimplemented (returns unchanged within limit, truncates at word boundary, ellipsis counts towardmaxLength, handles strings shorter than ellipsis)src/task-manager.tsremove(true/false),update(mutates stored task, false for unknown id), andsortByfor priority (high>medium>low),createdAt(oldest first), andstatussrc/date-utils.tsformatRelativeusesMath.roundinstead ofMath.floor— fixes day off-by-one (36h to "2 days ago")src/validator.tsisEmailaccepts long TLDs;isUrlaccepts URLs with an explicit portVerification
bun test-> 60 pass, 0 fail, 70 expect() callsAssumptions