fix: implement missing utils and fix edge-case bugs to pass all tests#222
Open
stooit wants to merge 1 commit into
Open
fix: implement missing utils and fix edge-case bugs to pass all tests#222stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- calculator.divide: throw on division by zero - string-utils.wordCount: collapse consecutive whitespace - string-utils.truncate: implement word-boundary truncation with ellipsis - task-manager: implement remove, update, and sortBy methods - date-utils.formatRelative: round hours-to-days (fixes off-by-one) - validator.isEmail: allow long TLDs; isUrl: allow explicit ports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the utility library. The full suite is now 60 pass / 0 fail, with no test files modified and no new dependencies added.
Changes
src/calculator.ts—dividenow throwsError("Division by zero")instead of returningInfinity.src/string-utils.tswordCountcollapses consecutive whitespace (trim().split(/\s+/)) so empty tokens aren't counted.truncateimplemented: word-boundary truncation with the ellipsis counted towardmaxLength.src/task-manager.ts— implemented/completedremove,update, andsortBy(priority weighting +createdAtoldest-first).src/date-utils.ts—formatRelativerounds hours→days (fixes the off-by-one; 36h → "2 days ago").src/validator.ts—isEmailaccepts long TLDs (e.g..museum);isUrlaccepts explicit ports (e.g.http://localhost:3000).Testing
bun test→ 60 pass, 0 fail, 70 expect() calls.Review notes / assumptions
truncatewith very smallmaxLength(≤3), the 12-hour rounding boundary informatRelative, and a pre-existing in-place mutation inTaskManager.update.🤖 Generated autonomously