fix: repair failing tests and implement missing utility functions#220
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and implement missing utility functions#220stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- calculator: divide now throws on division by zero instead of returning Infinity - string-utils: fix wordCount whitespace splitting, implement truncate with ellipsis and word-boundary handling - task-manager: complete missing/incomplete TaskManager methods - date-utils: fix off-by-one in formatRelative day rounding - validator: isEmail accepts long TLDs, isUrl accepts ports All 60 tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the utility library. Test suite now: 60 pass / 0 fail. No test files were modified and no dependencies were added.
Changes
dividenow throws on division by zero instead of returningInfinity.wordCountto collapse consecutive whitespace; implementedtruncatewith ellipsis + word-boundary handling.TaskManagermethods.formatRelative's day rounding.isEmailaccepts long TLDs (e.g..museum);isUrlaccepts ports (e.g.http://localhost:3000).Review hardening
A review pass caught three edge-case regressions in the initial fix (all near tested boundaries, none covered by existing tests) which were corrected:
date-utilshours-branch guard no longer rounds, removing a 23.5–24h dead zone.truncatereturns an ellipsis atmaxLength=3(boundary budget of 0).truncateno longer discards a word boundary at index 0.Assumptions
Testing
bun test→ 60 pass, 0 fail, 70 expect() calls.