fix: repair failing tests across utility library#219
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: divide now throws on division by zero - date-utils: formatRelative rounds days (fixes 36h off-by-one) - string-utils: implement truncate, slugify; fix wordCount for consecutive spaces - validator: fix isEmail TLD/subdomain handling, isUrl now accepts ports - task-manager: implement remove, update, and sortBy methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 failing tests across the TypeScript utility library. All 60 tests now pass with no dependencies added and no test files modified.
Changes
src/calculator.ts—dividenow throws"Division by zero"instead of returningInfinity.src/date-utils.ts—formatRelativeusesMath.roundfor day count, fixing the off-by-one (36h → "2 days ago").src/string-utils.ts— implementedtruncate(word-boundary aware, ellipsis counts towardmaxLength, handles strings shorter than ellipsis) andslugify; fixedwordCountto collapse consecutive whitespace.src/validator.ts—isEmailnow handles subdomains/long TLDs;isUrlaccepts URLs with ports.src/task-manager.ts— implementedremove,update, andsortBy(priority high>medium>low; createdAt oldest first).Verification
bun test→ 60 pass, 0 fail.Assumptions / notes
formatRelative(23h59m renders as "24 hours ago" rather than "1 day ago") was left untouched — not covered by any test, not introduced here. Worth a future follow-up.