fix: resolve all failing tests and type errors#71
Open
stooit wants to merge 1 commit into
Open
Conversation
…ages
- implement paginate() utility in shared (was a throwing stub)
- fix auth middleware HTTP method case-sensitivity ("post" -> "POST")
- add missing badRequest import in users route
- reconcile shared User field name to `username` to match contract
- add bun-types to tsconfig types to resolve process/bun:test globals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and TypeScript errors across the
apiandsharedpackages. Final state: 22 tests pass, 0 fail;tsc --noEmitclean.Changes
packages/shared/src/utils/pagination.ts— implementedpaginate()(was a stub throwingnot implemented). Handles page slicing, total/totalPages, page/pageSize, out-of-range pages, empty arrays, and partial last pages per the test contract.packages/api/src/middleware/auth.ts— fixed HTTP method case-sensitivity bug in the public-route check ("post"→"POST"), soPOST /usersis correctly treated as public. Also resolved theprocessglobal type error.packages/api/src/routes/users.ts— added the missingbadRequestimport and reconciled the user field name.Usertype / field naming — reconciled the inconsistent field name tousernameto match the contract exercised by the (unmodified) tests.tsconfig.json— addedbun-typestocompilerOptions.typesto resolveprocessandbun:testtype-resolution errors. No new dependencies added (bun-types already present).Verification
bun test→ 22 pass / 0 failbunx tsc --noEmit→ cleanConstraints honoured
Assumptions
Userfield name was inconsistent (userNamevsusername), the unmodifiable tests are the source of truth, so non-test code was aligned tousername.