fix: resolve failing tests and type errors across api and shared packages#69
Open
stooit wants to merge 1 commit into
Open
fix: resolve failing tests and type errors across api and shared packages#69stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests (now 22 pass / 0 fail) and eliminates all
tsc --noEmittype errors across theapiandsharedpackages.Changes
packages/shared/src/utils/pagination.ts— implemented thepaginate()stub (page slicing,total,totalPages,page/pageSize), with guards sototalPagesis0whentotal === 0orsize === 0(noInfinity).packages/shared/src/types.ts— renamedUser.userName→User.usernameto match the canonical field name the tests expect.packages/api/src/routes/users.ts— added the missingbadRequestimport and aligned field usage tousername.packages/api/src/middleware/auth.ts— fixed a case-sensitivity bug in the public-methods list (post→POST) soPOST /usersis correctly treated as a public, no-token route.tsconfig.json— added"types": ["bun-types"]to resolvebun:testmodule andprocessglobal type errors (uses the already-installedbun-types; no new dependencies).Verification
bun test→ 22 pass, 0 fail (4 files)bunx tsc --noEmit→ clean, zero errorsAssumptions
username(all-lowercase), since the tests use it throughout and tests are authoritative / were not modified.