fix: repair failing tests and type errors across api and shared packages#68
Open
stooit wants to merge 1 commit into
Open
fix: repair failing tests and type errors across api and shared packages#68stooit wants to merge 1 commit into
stooit wants to merge 1 commit into
Conversation
- Implement paginate() in shared (was a not-implemented stub) - Fix auth middleware public-method case sensitivity (post -> POST) - Add missing badRequest import in users route handler - Align User field name (userName -> username) across api package - Wire bun-types into tsconfig so tsc resolves bun:test and globals
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all failing tests and type errors in the multi-package TypeScript HTTP API repo. After this change: 22/22 tests pass and
tsc --noEmitreports zero errors.Root causes fixed
packages/shared/src/utils/pagination.tswas a stub throwingnot implemented. Implementedpaginate<T>()with 1-based paging: correct page slice,total,totalPages(ceil(total/size), 0 for empty), partial last page, and emptydatafor out-of-range pages / empty input.packages/api/src/middleware/auth.tslisted"post"(lowercase) in the public-methods allow-list, soPOST /users(uppercase per RFC 7231) incorrectly required a token. Fixed to"POST". Protected methods still fall through to the token check — no auth bypass introduced.packages/api/src/routes/users.tscalledbadRequestwithout importing it (ReferenceError). Added the import.userNamewhile the sharedUsertype and tests useusername. Aligned the API package tousername.tsccould not resolvebun:test, theprocessglobal, or Bun test globals. Wiredbun-typesinto tsconfig. No source logic affected.Verification
bun test→ 22 pass, 0 failnpx tsc --noEmit→ clean (exit 0)Constraints honored
bun-types).