fix: repair cross-package bugs causing test and type failures#58
Open
stooit wants to merge 1 commit into
Open
Conversation
- api.ts: use renamed useDebounce hook for useSearchDebounce re-export - date.ts: use en-AU dateStyle 'short' for day-first formatting - Button: forward aria-label to DOM with fallback for icon-only buttons - DataTable: use functional state updater to fix stale-closure on sort
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 4 cross-package bugs in the monorepo.
bun run testnow reports 13 pass / 0 fail, and there are no TypeScript errors in source code.Changes
apps/web/src/lib/api.tsuseThrottle→useDebouncein@e2e/utils, old name still imported, breaking theuseSearchDebouncere-exportuseDebouncepackages/utils/src/format/date.ts01/03/2024instead of day-first1/03/2024{ dateStyle: "short" }soen-AUcontrols orderingpackages/ui/src/components/Button/Button.tsxaria-labeldestructured but never applied to<button>aria-labelto the DOM, with fallback for icon-only buttonspackages/ui/src/components/DataTable/DataTable.tsxhandleSortread render-timesortDir, caught by controlled re-render testsetSortDir(prev => ...)Verification
bun run test→ 13 pass, 0 failtsc --noEmit→ no source errors (remainingbun:testmodule-resolution errors are confined to test files, pre-existing; test files were not modified per task constraints)Assumptions
dateStyle: "short"matches the existingformatDateTimeconvention in the same file and satisfies day-first test assertions.aria-labelfallback is a minimal safety net; descriptive labels remain the caller's responsibility.🤖 Generated with autonomous agent