Repository navigation
qt-cpp: Fix Windows Qt module parsing from CMake File API && Refine Module names for the telemetry - #596
Open
OrkunTokdemir wants to merge 5 commits into
Open
qt-cpp: Fix Windows Qt module parsing from CMake File API && Refine Module names for the telemetry#596OrkunTokdemir wants to merge 5 commits into
OrkunTokdemir wants to merge 5 commits into
Conversation
benchoq
previously approved these changes
Oct 13, 2026
OrkunTokdemir
force-pushed
the
orkun_telemetry_08_10_2026
branch
2 times, most recently
from
October 30, 2026 12:42
ffaf5e8 to
d6bf8f8
Compare
* Strip `lib` and architecture suffixes from Qt library names to return clean Qt module names such as Qt6Core and Qt6Pdf. * Remove trailing underscores and any suffixes after them from Qt library names
The previous helper in util.ts only handled kits and resolved the kit through the active folder instead of the project's own folder. Add CppProject.getMajorQtVersion(), which reads QT_VERSION through qtpaths for preset projects and uses the project's selected kit for kit projects, the same way the natvis command determines the version. Remove the old helper.
On macOS, Qt modules are read from framework names such as QtCore, which do not include the major Qt version. Telemetry therefore reported names like QtCore instead of Qt6Core. Determine the major version once per update and log a warning if it cannot be found. Only insert it after a leading Qt that is not already followed by 5 or 6, so Qt3DCore becomes Qt63DCore and names that already carry a version are left unchanged.
Replace the duplicated preset and kit handling with the project method. The kit is now resolved for the active project's folder. Add a silent parameter so the command still asks for a kit when none is selected.
Move the lib prefix, architecture suffix and underscore handling out of the Windows parser into refineModuleName(), together with the macOS major version insertion. The Windows parser keeps only the debug suffix removal. Remove duplicates after refining, since different raw names can end up as the same module name.
OrkunTokdemir
force-pushed
the
orkun_telemetry_08_10_2026
branch
from
November 18, 2026 14:50
761b50f to
c4fef91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip
liband architecture suffixes from Qt library namesto return clean Qt module names such as Qt6Core and Qt6Pdf.