Skip to content

feat(sandbox): 支持 create 和 connect 指定运行用户 - #461

Merged
miclle merged 2 commits into
qiniu:masterfrom
eirture:sbx-cn-user
Aug 11, 2026
Merged

feat(sandbox): 支持 create 和 connect 指定运行用户#461
miclle merged 2 commits into
qiniu:masterfrom
eirture:sbx-cn-user

Conversation

@eirture

@eirture eirture commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

变更内容

  • 为 sandbox create/connect 增加 --user/-u 参数
  • 将指定用户透传到终端 PTY 创建选项
  • 更新 create/connect 文档与命令文档测试

验证

  • go test ./cmd_test ./iqshell/sandbox/sandbox/operations

@qiniu-prow qiniu-prow Bot added the size/M label Aug 10, 2026

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in this review.

Verified with go test ./cmd_test ./iqshell/sandbox/sandbox/operations, git diff --check, and gofmt -l on changed Go files.

@eirture

eirture commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

/cc @miclle

@fennoai

fennoai Bot commented Aug 10, 2026

Copy link
Copy Markdown

@eirture Thanks for the trigger request.

This repository currently enforces member-only triggers, and your account does not have repository membership access, so Fenno cannot run for this request.

To proceed, you can:

  • Ask a repository maintainer to add you as a collaborator/member, or
  • Update .fennoai.yml and set require_member_to_trigger: false.

@qiniu-prow
qiniu-prow Bot requested a review from miclle August 10, 2026 09:50
Comment thread cmd/sandbox.go
@eirture
eirture requested a review from miclle August 11, 2026 01:51
@qiniu-prow

qiniu-prow Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: eirture, miclle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miclle miclle added the lgtm label Aug 11, 2026
@miclle
miclle merged commit 8726108 into qiniu:master Aug 11, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants