Skip to content

feat(sandbox): 配置创建和连接重试 - #458

Merged
miclle merged 1 commit into
qiniu:masterfrom
DROWNING2003:feat/sandbox-retry-config
Jul 30, 2026
Merged

feat(sandbox): 配置创建和连接重试#458
miclle merged 1 commit into
qiniu:masterfrom
DROWNING2003:feat/sandbox-retry-config

Conversation

@DROWNING2003

Copy link
Copy Markdown
Contributor

变更

  • 升级 github.com/qiniu/go-sdk/v7v7.27.0,使用创建请求幂等键与可重试调用支持。
  • qshell sandbox createqshell sandbox connect 增加 --retry-max0 禁用重试;未指定时保留 SANDBOX_RETRY_MAX 和 SDK 默认 5 次重试的行为。
  • 补充命令文档、CHANGELOG 和客户端配置测试。

验证

  • make test
  • gofmt -s -l .
  • staticcheck ./iqshell/sandbox/... ./cmd/...

全量 make lint 仍受仓库既有、与本 PR 无关的 staticcheck 告警影响。

通过 --retry-max 覆盖 Sandbox SDK 的重试上限,未指定时继续使用环境变量和默认配置。\n\n创建与连接命令现在可以显式禁用重试,并补充了相应文档和客户端回归测试。
@qiniu-prow

qiniu-prow Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Hi @DROWNING2003. Thanks for your PR.

I'm waiting for a qiniu member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qiniu-prow qiniu-prow Bot added the size/L label Jul 30, 2026

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found in this review. Focused review covered code quality, performance, security, and documentation accuracy. Verification: go test ./cmd ./iqshell/sandbox/... passed.

@miclle miclle left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qiniu-prow

qiniu-prow Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: DROWNING2003

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@miclle
miclle merged commit 4c647cd into qiniu:master Jul 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants