Feature/feat datset 14 invenio rdm credentials - #1499
Open
sven1103 wants to merge 18 commits into
Open
Conversation
Implement Checkpoints 1-9 of the implementation plan: Database & Config: - New user_external_credential table (source-agnostic, per user/instance) - Vault config property for dedicated AES-256 master key alias Encryption (ADR-0002 S2): - CredentialEncryptor port (application layer) - AesGcmCredentialEncryptor impl (infrastructure, AES/GCM/NoPadding) - Per-token random 12-byte nonce, 128-bit GCM tag - 10 unit tests covering roundtrip, nonce uniqueness, wrong key, etc. Domain model: - UserExternalCredential entity (JPA + domain, same-class convention) - CredentialStatus enum (VALID / INVALIDATED) - UserExternalCredentialRepository port - Spring Data JPA repo + repository impl Validation layer (composite dispatcher pattern): - ExternalCredentialValidator port (application layer) - CredentialValidatorAdapter interface (infrastructure, per-provider) - InvenioRdmCredentialValidatorAdapter (GET /api/users, per OpenAPI spec) - SourceTypeDispatchingCredentialValidator (routes by SourceType) - CredentialValidationException Client enhancements: - InvenioRdmClient.getAuthenticatedUser() (new endpoint) - InvenioRdmClient.search()/getRecord() (auth-header overloads) - SourceInstanceDescriptor now carries sourceType Application service: - ExternalCredentialService interface + DefaultExternalCredentialService - Sealed AddCredentialResult (Success/InvalidToken/ServiceError/UnknownInstance) - Token zeroed in finally block after add DatasetSource adapter: - InvenioRdmDatasetSource now resolves per-user tokens for authenticated search/resolve (decryption boundary ADR-0002 D1 enforced) Spring wiring: - InvenioRdmConfiguration registers all new beans - Dispatcher configured for INVENIO_RDM (extensible for future providers) All 263 existing tests still pass (0 failures, 0 errors).
Implement Checkpoint 10 of the implementation plan: - Route: /external-providers (alongside /profile and /personal-access-token) - Layout: heading + benefit text (AC-6), list of configured instances, Add/Remove buttons - Add Token dialog: PasswordField input with no echo, validate-then-save flow - Token field is cleared on dialog close (no stale secrets in component state) - Status indicators: green check for connected, red X for not configured - Help link to standard InvenioRDM token settings page - Toast notifications for success, invalid token, transient errors - Error messages are generic (no upstream details leaked) - Token zeroed by the service; field cleared on close
…lidation - AesGcmCredentialEncryptor now validates that the master key material is exactly 32 bytes (AES-256) and rejects AES-128/AES-192 keys at construction time - InvenioRdmConfiguration reads vault entry as Base64-encoded string, decodes, and validates the decoded length is exactly 32 bytes before constructing the SecretKey - Vault provisioning instructions updated to document Base64 encoding requirement (e.g., openssl rand -base64 32) - Implementation plan and migration guides updated to reflect new key handling requirements - Checklist updated to include key size validation checkpoints This fixes the provisioning issue where the previous 32-byte raw string requirement was not well-supported
- Redesign External Providers page with card-based layout - Colored left border accents (green/gray/red) - Top-right action buttons (Connect/Disconnect) - Provider home page links - Configured date display - Add verification sidebar (right slide-in drawer) - Verify all tokens in parallel - Skip providers without tokens (not connected state) - Real-time status updates (Valid/Invalid/Error) - Inline Reconnect action for invalid tokens - Refreshes on close to sync with main view - Add manual token validation to domain layer - validateCredential() decrypts stored token and validates - Updates credential status to VALID or INVALIDATED per ADR-0002 - Only explicit user action triggers validation (no silent updates) - Handle invalidated credentials gracefully - Invalidated cards show two-button recovery: [Reconnect] [Disconnect] - Sidebar marks invalid tokens red with reason and Reconnect link - Successful reconnection from either surface refreshes both views - Fix provider URL rendering (use base-url field, not display name parsing) - Add toolbar with global 'Verify connections' button - Add security reassurance text and page padding
…atset-14-invenio-rdm-credentials
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue and Traceability
Linked Task Issue
Requirement IDs Addressed
Requirement Update Status
docs/requirements.mdhave been updated to reflect this implementation.Justification (if applicable)
Changes Summary
Modified Areas
domain/model/, domain events, aggregates)application/services, use cases)views/components, Vaadin routes)sql/, DDL changes)Behavioral Changes
Sensitive Changes Requiring Review
sql/complete-schema.sql, table/column DDL)security/, ACL setup, authentication/authorization)docs/fair/, RO-Crate builder logic)docs/requirements.md)Pre-Submission Checklist
C(constraint) IDs are listed in the Requirement IDs sectionNotes for Reviewers