Repository navigation
Handle missing datum strips and correct RC6 slow tests - #2183
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2182.
Change
Only rank coincident datum stems when their requested view side has a strip. A missing strip now reaches the existing corridor no-strip path, which runs the normal legal fallback and records
pmi_droppedif the datum cannot be placed. Imported surface-normal datums remain restricted to their proven side.Reproduction and checks
build_drawing(..., pmi="annotate")regression declares an imported side-view datum on the absent left strip and a separate PMI control frame. On unchanged main it raises the reportedAttributeErrorat_gdt.py:792.pmi_droppedissue, and the solve trace proves the left strip wasNoneand the datum's outcome wasno_strip.test_gdt_placement.pyandtest_strip_zones.pypassed.scripts/pr-check --staticandgit diff --checkpassed.RC6 slow-gate correction
The post-merge main slow run for #2181 had two stale expectations:
TestTheCaseStudystill expected the automatic plate drawing to use A1. On current main, measured throughbuild_drawing, both the automatic and explicitly two-principal-view builds use A2 at 1:1, have the same three views and 34 annotation names, and clean lint. The test now checks automatic/manual parity instead of the obsolete A1/A2 contrast.Sheetreplay still chooses A4 at 2:1 with a placed detail and retains the manufacturing meaning; the test checks those two observed arrangements separately.Both isolated slow nodes and static checks pass locally. These are test corrections for #2181's already merged behavior; they change no production layout code.
Architecture
ADR 1 keeps the same compiler and annotation pass. ADR 2 retains the shared corridor solver and its existing no-strip fallback. ADR 3 recognition and ADR 4 authored meaning are unchanged. ADR 5 reports an unplaceable sourced datum while keeping other PMI instead of aborting the build. No ADR boundary or invariant changes.
ADR 2 still contains the previously logged contradiction between its no-automatic-principal-removal sentence and the current thin-plate behavior. The record itself is unchanged pending maintainer sign-off; #1130 tracks it.