Add experimental Hugging Face .tok tokenizer path - #23139
Draft
JacobSzwejbka wants to merge 4 commits into
Draft
JacobSzwejbka wants to merge 4 commits into
JacobSzwejbka wants to merge 4 commits into
Conversation
Point at the rebased tokenizer dependency with corrected BOS/EOS semantics, safe decoder gating, and regression coverage. Apply the required CMake formatting. AI-assisted-by: Codex
AI-assisted-by: Codex
Generated with assistance from Codex.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23139
Note: Links to docs will display an error until the docs builds have been completed. ❌ 48 New Failures, 6 Unclassified FailuresAs of commit 25dddf4 with merge base 83c4dc1 ( NEW FAILURES - The following jobs have failed:
UNCLASSIFIED FAILURES - DrCI could not classify the following jobs because the workflow did not run on the merge base. The failures may be pre-existing on trunk or introduced by this PR:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is the experimental
.tokwiring follow-up to pytorch/executorch#22548 and meta-pytorch/tokenizers#218. Do not merge it before either dependency.It adds the ExecuTorch format selector needed to build the Rust tokenizer as
.tok-only or with both JSON and.toksupport. The default remains JSON..tokis not part of Hugging Face tokenizers v1.0.0-rc.2. The tokenizer dependency draft pins an experimental Hugging Face branch commit and is explicitly blocked on that functionality landing in a protected upstream branch or release.Because this PR is stacked, GitHub currently shows its JSON base changes too. After #22548 and the tokenizer dependency land, rebase this branch and update the tokenizer submodule pointer; the remaining diff will be only the experimental format selection.
AI-assisted by Codex.