Repository navigation
Remove unused type error suppressions (landing group 94) - #6527
Open
maggiemoss wants to merge 1 commit into
Open
maggiemoss wants to merge 1 commit into
maggiemoss wants to merge 1 commit into
Conversation
Contributor
|
@maggiemoss has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126418570. |
Summary: X-link: meta-recsys/recir#469 X-link: meta-pytorch/torchrec#4915 X-link: meta-pytorch/torchcomms#4492 X-link: https://github.com/facebookresearch/FBGEMM/pull/3382 X-link: pytorch/pytorch#201564 X-link: meta-pytorch/tnt#1102 X-link: facebookresearch/DCPerf#926 X-link: facebookincubator/MCGrad#352 X-link: facebookexperimental/ptx-anneal#7 X-link: meta/Ax#5305 This Phabricator Diff was generated from Pyrefly type-checker output by the per-target upgrade tool. It was not generated by an AI coding system. It changes only type-error suppression comments: it removes suppressions that are no longer needed and adds `# pyrefly: ignore[...]` comments for remaining errors. It does not change Python runtime behavior or application logic. Landing group: `a4aafcc16d82133483419621eafd44f23c4eacfecab0767af53ff3205d58abd5` (attempt 1, 18 batches, 901 files) Merged patch SHA-256: `00e21a920ceb543a54e214fecec9b48113a48969491c818d566d61aeb10ea3d5` Excluded sensitive files: 3 #pyreupgrade Reviewed By: maggiemoss Differential Revision: D126418570
maggiemoss
force-pushed
the
export-D126418570
branch
from
October 20, 2026 17:48
89148c0 to
3a76331
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
X-link: meta-recsys/recir#469
X-link: meta-pytorch/torchrec#4915
X-link: meta-pytorch/torchcomms#4492
X-link: https://github.com/facebookresearch/FBGEMM/pull/3382
X-link: pytorch/pytorch#201564
X-link: meta-pytorch/tnt#1102
X-link: facebookresearch/DCPerf#926
X-link: facebookincubator/MCGrad#352
X-link: facebookexperimental/ptx-anneal#7
X-link: meta/Ax#5305
This Phabricator Diff was generated from Pyrefly type-checker output by the per-target upgrade tool. It was not generated by an AI coding system.
It changes only type-error suppression comments: it removes suppressions that are no longer needed and adds
# pyrefly: ignore[...]comments for remaining errors. It does not change Python runtime behavior or application logic.Landing group:
a4aafcc16d82133483419621eafd44f23c4eacfecab0767af53ff3205d58abd5(attempt 1, 18 batches, 901 files)Merged patch SHA-256:
00e21a920ceb543a54e214fecec9b48113a48969491c818d566d61aeb10ea3d5Excluded sensitive files: 3
#pyreupgrade
Reviewed By: maggiemoss
Differential Revision: D126418570