gh-85076: Document exceptions that can be raised by importlib.import_module

[kj7rrv]

Closes #85076

• Issue: Document exceptions raised by importlib.import #85076

[bedevere-bot]

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

[FFY00]

Hi @kj7rrv this looks good, thank you! Can you add the missing news entry, as the bot requested?

[kj7rrv]

@FFY00 I didn't because it's just a documentation change.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

[zormit]

Hi @kj7rrv, are you still interested in getting this merged? I found this by looking at <easy> issues and I'd be happy to help make the changes go to upstream. I have tried adding to the discussion -- if you personally like it, maybe you can update the branch and PR accordingly, s.t. it gets another round of review?

P.S:. If you're busy / have other priorities, I can also open another PR and we can close this one. But given there is already a 2nd open PR, I didn't want to add a 3rd one 😅

[kj7rrv]

@zormit Hi! I applied your suggested change. I am still interested in having it merged; is there anything else that needs to be changed?

[zormit]

I'm not sure why it bedevere still says this is awaiting changes, it should now, after you changed something be awaiting review? 🤔 (that's me, trying to understand the PR state machine)

@kj7rrv Also a clarifying question: Did you mean to apply my changes? I think you have accepted the changes by Brett instead of mine. They are a bit less detailed. It would be okay for me, I could approve it, given it's much better than nothing, but I would be curious about your reasoning behind it.

[brettcannon]

I'm not sure why it bedevere still says this is awaiting changes

It's because @kj7rrv didn't say the triggering phrase as specified in #94662 (comment) to refresh review requests.

[bombs-kim]

@kj7rrv could you add a comment that includes this line?
"I have made the requested changes; please review again"

[kj7rrv]

I have made the requested changes; please review again.

[bedevere-app]

Thanks for making the requested changes!

@brettcannon, @FFY00: please review the changes made to this pull request.

[hauntsaninja]

Looks good!

Some phrasing like "cannot be found or loaded" instead of "cannot be imported" might make the sentence more technically accurate for modules like 1/0 which could also conceivably be described as not being able to be imported, but that's a bit of a nit

[brettcannon]

@kj7rrv thanks for the PR and apologies for the delay!

@hauntsaninja thanks for the review!