Skip to content

bpo-40307: Preserve manager Client in multiprocessing managers#19609

Open
amol- wants to merge 4 commits intopython:mainfrom
amol-:fix-syncmanager-40307
Open

bpo-40307: Preserve manager Client in multiprocessing managers#19609
amol- wants to merge 4 commits intopython:mainfrom
amol-:fix-syncmanager-40307

Conversation

@amol-
Copy link
Copy Markdown

@amol- amol- commented Apr 19, 2020

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@amol-

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

Copy link
Copy Markdown

@remilapeyre remilapeyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @amol-, thanks for looking into the issue!

The fix and the tests look correct. The changes are not trivial though so you will need the sign the CLA and to add a blurb (https://devguide.python.org/committing/#what-s-new-and-news-entries) to describe the changes, you can do this using https://blurb-it.herokuapp.com/.

@amol-
Copy link
Copy Markdown
Author

amol- commented Apr 20, 2020

@remilapeyre I should have signed the CLA before submitting the PR, but I guess it might take a while before it figures. Let me know if it worked or if there is any action pending on my side.

PS: I tried to add a NEWS entry using blurp-it, let me know if the style suites what's expected.

Comment thread Misc/NEWS.d/next/Library/2020-04-20-10-40-54.bpo-40307.b4YXXY.rst Outdated
@remilapeyre
Copy link
Copy Markdown

The bot should find it later then. Thanks for adding the blob, it should be in the present tense and there is a small typo.

@remilapeyre
Copy link
Copy Markdown

Hi @amol-, can you please fix the conflix with master?

@amol-
Copy link
Copy Markdown
Author

amol- commented Feb 22, 2021

@remilapeyre Just wanted to follow-up to make sure there isn't anything else pending for this PR and it's only waiting for review. Let me know if there is any way I can help.

@amol- amol- force-pushed the fix-syncmanager-40307 branch from 28733c6 to ed43e0b Compare February 27, 2026 17:09
@amol- amol- requested a review from gpshead as a code owner February 27, 2026 17:09
@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented Feb 27, 2026

All commit authors signed the Contributor License Agreement.

CLA signed

@amol- amol- force-pushed the fix-syncmanager-40307 branch from bf911c8 to dc3b893 Compare February 27, 2026 17:40
@amol-
Copy link
Copy Markdown
Author

amol- commented Feb 27, 2026

@remilapeyre sorry I resurrected this after years, but the issue appeared to me again in another project and thus I remembered about this PR. I rebased it against main and it still seems to work as expected and address the associated issue.

I guess it would need someone to review this one at this point.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2026

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting core review stale Stale PR or inactive for long period of time. topic-multiprocessing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

multiprocessing.BaseManager does not retain Client type.

6 participants