Skip to content

Allow graceful error handling in messages.py when MIMEText object encodes payload#15147

Closed
F1uxCapacitor wants to merge 2 commits intopython:mainfrom
F1uxCapacitor:patch-1
Closed

Allow graceful error handling in messages.py when MIMEText object encodes payload#15147
F1uxCapacitor wants to merge 2 commits intopython:mainfrom
F1uxCapacitor:patch-1

Conversation

@F1uxCapacitor
Copy link
Copy Markdown

Allow for more graceful encoding when errors are encountered.

Allow for more graceful encoding when errors are encountered.
@F1uxCapacitor F1uxCapacitor requested a review from a team as a code owner August 6, 2019 17:24
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@matrixise
Copy link
Copy Markdown
Member

matrixise commented Sep 11, 2019

Hi @F1uxCapacitor,

Thank you for your contribution but

  1. Could you sign the CLA as recommended by @the-knights-who-say-ni
  2. Could you change the title of your PR and your commit because the current one is not clear?
  3. Create a bpo issue and assign the bpo issue to this PR.

Thank you

@F1uxCapacitor F1uxCapacitor changed the title Update message.py Allow graceful error handling in messages.py when MIMEText object encodes content Sep 17, 2019
@F1uxCapacitor F1uxCapacitor changed the title Allow graceful error handling in messages.py when MIMEText object encodes content Allow graceful error handling in messages.py when MIMEText object encodes payload Sep 17, 2019
@F1uxCapacitor
Copy link
Copy Markdown
Author

F1uxCapacitor commented Sep 17, 2019 via email

@csabella csabella requested review from a team and removed request for a team January 26, 2020 01:10
@erlend-aasland erlend-aasland added the pending The issue will be closed if no feedback is provided label Jan 23, 2023
@bedevere-bot
Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@arhadthedev
Copy link
Copy Markdown
Member

Should we allow non-conformant (aka potentially broken, malformed, or misdecoded) Unicode texts be sent into the wild?

@erlend-aasland
Copy link
Copy Markdown
Contributor

@F1uxCapacitor, can you please create an issue for this PR?

@python-cla-bot
Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

CLA signed

@erlend-aasland
Copy link
Copy Markdown
Contributor

No response for more than a year. Closing.

@erlend-aasland erlend-aasland removed the pending The issue will be closed if no feedback is provided label Sep 18, 2025
@bitdancer
Copy link
Copy Markdown
Member

By the way, the answer to "Should we allow non-conformant Unicode texts be sent into the wild?" is no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants