gh-145678: Fix use-after-free in itertools.groupby _grouper_next()

Lib/test/test_itertools.py

@@ -754,6 +754,40 @@ def keys():
         next(g)
         next(g)  # must pass with address sanitizer
 
+    def test_grouper_next_reentrant_eq_does_not_crash(self):
+        # regression test for gh-145678: _grouper_next() did not protect
+        # gbo->currkey / igo->tgtkey before calling PyObject_RichCompareBool,
+        # so a reentrant __eq__ that advanced the parent groupby could free
+        # those objects while they were still being compared (use-after-free).
+        outer_grouper = None
+
+        class Key:
+            def __init__(self, val, do_advance):
+                self.val = val
+                self.do_advance = do_advance
+
+            def __eq__(self, other):
+                if self.do_advance:
+                    self.do_advance = False
+                    # Advance the parent groupby iterator from inside __eq__,
+                    # which calls groupby_step() and frees the old currkey.
+                    try:
+                        next(outer_grouper)
+                    except StopIteration:
+                        pass
+                    return NotImplemented
+                return self.val == other.val
+
+            def __hash__(self):
+                return hash(self.val)
+
+        values = [1, 1, 2]
+        keys_iter = iter([Key(1, True), Key(1, False), Key(2, False)])
+        g = itertools.groupby(values, lambda _: next(keys_iter))
+        outer_grouper = g
+        k, grp = next(g)
+        list(grp)  # must not crash with address sanitizer
+
     def test_filter(self):
         self.assertEqual(list(filter(isEven, range(6))), [0,2,4])
         self.assertEqual(list(filter(None, [0,1,0,2,0])), [1,2])

Misc/NEWS.d/next/Library/2026-03-09-00-00-00.gh-issue-145678.grouper-uaf.rst

@@ -0,0 +1,7 @@
+Fix a use-after-free in :func:`itertools.groupby`: the internal
+``_grouper_next()`` function did not hold strong references to
+``gbo->currkey`` and ``igo->tgtkey`` before calling
+:c:func:`PyObject_RichCompareBool`, so a re-entrant ``__eq__`` that advanced
+the parent iterator (triggering ``groupby_step()`` and ``Py_XSETREF`` on
+``currkey``) could free those objects while they were still being compared.
+The fix mirrors the protection added in :gh:`143543` for ``groupby_next()``.

Modules/itertoolsmodule.c

@@ -678,7 +678,17 @@ _grouper_next(PyObject *op)
     }
 
     assert(gbo->currkey != NULL);
-    rcmp = PyObject_RichCompareBool(igo->tgtkey, gbo->currkey, Py_EQ);
+    /* A user-defined __eq__ can re-enter groupby (via the parent iterator)
+       and call groupby_step(), which frees gbo->currkey via Py_XSETREF while
+       we are still comparing it.  Take local snapshots with strong references
+       so INCREF/DECREF apply to the same objects even under re-entrancy. */
+    PyObject *tgtkey = igo->tgtkey;
+    PyObject *currkey = gbo->currkey;
+    Py_INCREF(tgtkey);
+    Py_INCREF(currkey);
+    rcmp = PyObject_RichCompareBool(tgtkey, currkey, Py_EQ);
+    Py_DECREF(tgtkey);
+    Py_DECREF(currkey);
     if (rcmp <= 0)
         /* got any error or current group is end */
         return NULL;