-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
gh-145117: fix pprint.isreadable() for non-finite float and complex values #145120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zetzschest
wants to merge
8
commits into
python:main
Choose a base branch
from
stefanzetzsche:fix/pprint_isreadable_float_specials_v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b11ec5d
gh-145117: Fix pprint.isreadable() returning True for inf/nan
stefanzetzsche 8ce72a3
Merge branch 'main' into fix/pprint_isreadable_float_specials_v2
zetzschest 56443e5
gh-145117: use cmath.isfinite() to also fix complex specials
stefanzetzsche 6090073
Merge origin/main into fix/pprint_isreadable_float_specials_v2
stefanzetzsche 3e8b82c
Merge branch 'fix/pprint_isreadable_float_specials_v2' of https://git…
stefanzetzsche b39cad5
gh-145117: extend test_isreadable_float_specials to cover complex non…
stefanzetzsche a0d1fff
gh-145117: update NEWS entry to mention complex non-finite values
stefanzetzsche b21405a
Merge remote-tracking branch 'origin/main' into fix/pprint_isreadable…
stefanzetzsche File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
Misc/NEWS.d/next/Library/2026-02-22-00-00-00.gh-issue-145117.pPrint.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Fix :func:`pprint.isreadable` to return ``False`` for ``float('inf')``, | ||
| ``float('-inf')``, and ``float('nan')``. Their string representations | ||
| (``inf``, ``-inf``, ``nan``) are not valid Python literals and cannot | ||
| be reconstructed via :func:`eval`, violating the documented contract of | ||
| :func:`~pprint.isreadable`. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.