-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
gh-144285: Improve AttributeError attribute suggestions
#144299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pablogsal
merged 21 commits into
python:main
from
johnslavik:feat-clearer-name-suggestions
Feb 12, 2026
+49
−37
Merged
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
726189c
Use "instead of" technique for clearer name suggestions
johnslavik 600ede5
Prepend with a dot for better understanding
johnslavik 89242f3
Don't change `NameError` messages
johnslavik 32aa69d
Merge branch 'main' into feat-clearer-name-suggestions
johnslavik 5ab2311
Bring back the TOCTOU for readability
johnslavik 03b1f45
Remove `:` in `AttributeError` path
johnslavik d0f68a0
Don't prepend with dots in non-ASCII case
johnslavik fce7867
Fix typo
johnslavik 6dc6612
Update tests
johnslavik 79539b0
Add news entry
johnslavik 6054352
Less words, more meaning
johnslavik f80d3da
Fix more tests
johnslavik c973a52
Handle non-ASCII cases correctly
johnslavik 01337cf
Extend the normalized suggestions test
johnslavik 97e075b
Make the extended test more strict
johnslavik 107e7c0
Update news entry to reflect what happened
johnslavik 57f08a6
Fix wording
johnslavik 5bfdc3e
Final plumbing
johnslavik 5e14b5f
Make the news entry easier
johnslavik b253b1c
Remove unneeded comment (code is self-explanatory)
johnslavik 5a25fea
Fix colon usage inconsistency
johnslavik File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Misc/NEWS.d/next/Library/2026-02-07-16-31-42.gh-issue-144285.iyH9iL.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| Attribute suggestions in :exc:`AttributeError` tracebacks are now formatted differently | ||
| to make them easier to understand, for example: ``Did you mean '.datetime.now' instead of '.now'``. | ||
| Contributed by Bartosz Sławecki. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.