gh-142918: Fix Context.items/keys/values docstrings (return iterators, not lists)#142919
Open
hyongtao-code wants to merge 3 commits intopython:mainfrom
Open
gh-142918: Fix Context.items/keys/values docstrings (return iterators, not lists)#142919hyongtao-code wants to merge 3 commits intopython:mainfrom
hyongtao-code wants to merge 3 commits intopython:mainfrom
Conversation
_contextvars.Context.items(), .keys(), and .values() return iterator objects, but their docstrings incorrectly claim they return lists. Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
Update the Argument Clinic docstrings in Python/context.c and regenerate Python/clinic/context.c.h. No behavior change. Signed-off-by: Yongtao Huang <yongtaoh2022@gmail.com>
Member
StanFromIreland
left a comment
There was a problem hiding this comment.
The docs also use "a list," it should be fixed too.
Contributor
Author
|
Thanks for the reminder — the corresponding docs have been updated. |
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_contextvars.Context.items(),.keys(), and.values()return iterator objects, but their docstrings incorrectly claim they return lists.Taking items() as an example, its call chain is
_contextvars_Context_items_impl()→_PyHamt_NewIterItems().The comment on _contextvars_Context_items_impl states that it returns a
list, but the comment on _PyHamt_NewIterItems indicates that it returns aniterator.Update the Argument Clinic docstrings in Python/context.c and regenerate
Python/clinic/context.c.h. No behavior change.📚 Documentation preview 📚: https://cpython-previews--142919.org.readthedocs.build/en/142919/library/contextvars.html?readthedocs-diff=true&readthedocs-diff-chunk=1
Script to reproduce
Result without the patch
Result with the patch
Signed-off-by: Yongtao Huang yongtaoh2022@gmail.com