gh-142438: Added missing GIL release in _PySSL_keylog_callback when keylog_bio is unset#142439
Merged
corona10 merged 1 commit intopython:mainfrom Dec 11, 2025
Merged
Conversation
corona10
reviewed
Dec 10, 2025
picnixz
reviewed
Dec 10, 2025
picnixz
reviewed
Dec 10, 2025
Comment on lines
+1
to
+2
| Added a missing GIL release in _PySSL_keylog_callback when keylog_bio is | ||
| unset, preventing a leaked GIL in that early-return path. |
Member
There was a problem hiding this comment.
We could (1) either remove the NEWS entry or (2) indicate what could be wrong from a public API perspective. I don't want to expose implementation details like this.
Contributor
Author
There was a problem hiding this comment.
The concept of not wanting to expose implementation details on a FOSS application. I don't understand.
Member
There was a problem hiding this comment.
This is because we don't want the changelog to be burdened by implementation details that no one cares about and that no one could see from a pure Python perspective.
…when keylog_bio is unset In the early return, threadstate is leaked. We have to release it.
LumioseSil
force-pushed
the
Prevent-GIL-leak
branch
from
a4787d1 to
929d1f5
Compare
fatelei
pushed a commit
to fatelei/cpython
that referenced
this pull request
Dec 12, 2025
…when keylog_bio is unset (pythongh-142439)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the early return, threadstate is leaked.
We have to release it.