Skip to content

gh-141648: Fix clearing of executors #141649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fidget-Spinner wants to merge 5 commits into from
+7 −2
Closed

gh-141648: Fix clearing of executors #141649

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5fd5336
Fix clearing of executors
Fidget-Spinner Nov 17, 2025
1b99fc1
set to NULL first
Fidget-Spinner Nov 17, 2025
9db8638
Update Python/optimizer.c
Fidget-Spinner Nov 17, 2025
d0d495f
slight fix
Fidget-Spinner Nov 17, 2025
228e609
Merge remote-tracking branch 'upstream/main' into fix-executor-clearing
Fidget-Spinner Nov 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Python/optimizer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1669,12 +1669,15 @@ executor_clear(PyObject *op)
* free the executor unless we hold a strong reference to it
*/
_PyExecutorObject *cold = _PyExecutor_GetColdExecutor();
_PyExecutorObject *cold_dynamic = _PyExecutor_GetColdDynamicExecutor();
Py_INCREF(executor);
for (uint32_t i = 0; i < executor->exit_count; i++) {
executor->exits[i].temperature = initial_unreachable_backoff_counter();
_PyExecutorObject *e = executor->exits[i].executor;
executor->exits[i].executor = cold;
Py_DECREF(e);
executor->exits[i].executor = NULL;
if (e != cold && e != cold_dynamic) {
executor_clear(e);
Comment thread
Fidget-Spinner marked this conversation as resolved.
Outdated
}
}
_Py_ExecutorDetach(executor);
Py_DECREF(executor);
Expand Down
Loading