gh-51338: Fix shlex to preserve newlines after comments in POSIX mode#141604
Open
kamilturek wants to merge 1 commit intopython:mainfrom
Open
gh-51338: Fix shlex to preserve newlines after comments in POSIX mode#141604kamilturek wants to merge 1 commit intopython:mainfrom
shlex to preserve newlines after comments in POSIX mode#141604kamilturek wants to merge 1 commit intopython:mainfrom
Conversation
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to POSIX standard, newlines are NOT part of comments. Previously,
shlexincorrectly consumed newlines when skipping comments, causing them to be lost even when excluded from thewhitespaceattribute.https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_03