Skip to content

gh-44968: Add "Reload from Disk" feature to IDLE#141574

Closed
ashm-dev wants to merge 127 commits intopython:mainfrom
ashm-dev:idle
Closed

gh-44968: Add "Reload from Disk" feature to IDLE#141574
ashm-dev wants to merge 127 commits intopython:mainfrom
ashm-dev:idle

Conversation

@ashm-dev
Copy link
Copy Markdown
Contributor

@ashm-dev ashm-dev commented Nov 14, 2025 •
edited by bedevere-app Bot
Loading

@bedevere-app bedevere-app Bot mentioned this pull request Nov 14, 2025
Open
sharktide
sharktide reviewed Nov 15, 2025
View reviewed changes
Comment thread Lib/idlelib/iomenu.py Outdated
sharktide
sharktide reviewed Nov 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sharktide sharktide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also don’t think we should restore the cursor position since a file’s line numbers could also change when it is edited and it could cause confusion.

ashm-dev and others added 2 commits November 15, 2025 09:47
@ashm-dev @sharktide
Update Lib/idlelib/iomenu.py
884758b 
Co-authored-by: R.C.M <sharktidedev@gmail.com>
@ashm-dev
Simplify file reload by removing cursor restoration
d6f54a2 
Removed cursor position restoration logic during file reload.
@ashm-dev
Copy link
Copy Markdown
Contributor Author

ashm-dev commented Nov 15, 2025

I also don’t think we should restore the cursor position since a file’s line numbers could also change when it is edited and it could cause confusion.

Rewrote it, now it won't save cursor position.

@ashm-dev ashm-dev requested a review from sharktide November 15, 2025 07:24
picnixz
picnixz previously requested changes Nov 15, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rely more on unittest.mock.patch() as well as mock features directly. In addition add a What's New entry in addition to the NEWS entry.

Comment thread Lib/idlelib/idle_test/test_iomenu.py
Comment thread Lib/idlelib/idle_test/test_iomenu.py Outdated
Comment thread Lib/idlelib/idle_test/test_iomenu.py Outdated
Comment thread Lib/idlelib/idle_test/test_iomenu.py Outdated
Comment thread Lib/idlelib/idle_test/test_iomenu.py Outdated
Comment thread Lib/idlelib/idle_test/test_iomenu.py Outdated
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Nov 15, 2025

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ashm-dev ashm-dev requested a review from AA-Turner as a code owner November 15, 2025 22:28
@ashm-dev
Copy link
Copy Markdown
Contributor Author

ashm-dev commented Nov 15, 2025

I have made the requested changes; please review again

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented Dec 8, 2025

The following commit authors need to sign the Contributor License Agreement:

CLA not signed

@ashm-dev ashm-dev closed this Dec 8, 2025
@ashm-dev ashm-dev deleted the idle branch December 8, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz requested changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

@gaogaotiantian gaogaotiantian Awaiting requested review from gaogaotiantian gaogaotiantian is a code owner

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin

@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

@willingc willingc Awaiting requested review from willingc willingc is a code owner

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

@ZeroIntensity ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner

@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping is a code owner

@freakboy3742 freakboy3742 Awaiting requested review from freakboy3742 freakboy3742 is a code owner

@encukou encukou Awaiting requested review from encukou encukou is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

+1 more reviewer

@sharktide sharktide sharktide left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.