Skip to content

gh-138407: avoid useless join operation when calculate the hash vaule for pathlib.Path #138645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zheaoli wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-138407: avoid useless join operation when calculate the hash vaule for pathlib.Path #138645

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1a76da
gh-138407: avoid useless join operation when calculate the hash vaule…
Zheaoli Sep 8, 2025
6f9b72d
add test and news
Zheaoli Sep 8, 2025
eff160a
Fix test
Zheaoli Sep 8, 2025
28bff4e
fix review idea
Zheaoli Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion Lib/pathlib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,14 @@ def __hash__(self):
try:
return self._hash
except AttributeError:
self._hash = hash(self._str_normcase)
hash_data = self._tail
if self._drv or self._root:
hash_data = [self._drv + self._root] + self._tail
elif self._tail and self.parser.splitdrive(self._tail[0])[0]:
hash_data = ['.'] + self._tail
Comment thread
Zheaoli marked this conversation as resolved.
Outdated
Comment thread
Zheaoli marked this conversation as resolved.
Outdated
if self.parser is not posixpath:
hash_data = [part.lower() for part in hash_data]
self._hash = hash(tuple(hash_data))
return self._hash

def __eq__(self, other):
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-09-08-19-04-23.gh-issue-138407.BqNAfi.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Avoid useless join operation when calculate the hash vaule for pathlib.Path.
Loading