gh-138584: Fix missing type2test in Lib/tests/list_tests.py #138590
Merged
picnixz merged 3 commits intopython:mainfrom Sep 7, 2025
Merged
gh-138584: Fix missing type2test in Lib/tests/list_tests.py #138590picnixz merged 3 commits intopython:mainfrom
picnixz merged 3 commits intopython:mainfrom
Conversation
picnixz
reviewed
Sep 6, 2025
picnixz
reviewed
Sep 6, 2025
picnixz
approved these changes
Sep 7, 2025
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
I've checked the usage of this class but I think we can just assume that we'll only be using it for list and userlist so it's fine to keep the error message as is. If it needs to be changed later, we'll just refactor the tests nicely.
picnixz
added
needs backport to 3.13
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2025
…ythonGH-138590) Some common tests in `test.list_tests.CommonTest` explicitly tested `list` instead of testing the underlying list-like type defined in `type2test`. --------- (cherry picked from commit d7b9ea5) Co-authored-by: dbXD320 <devanshbaghla320@gmail.com> Co-authored-by: Devansh Baghla <devanshbaghla34@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 7, 2025
…ythonGH-138590) Some common tests in `test.list_tests.CommonTest` explicitly tested `list` instead of testing the underlying list-like type defined in `type2test`. --------- (cherry picked from commit d7b9ea5) Co-authored-by: dbXD320 <devanshbaghla320@gmail.com> Co-authored-by: Devansh Baghla <devanshbaghla34@gmail.com>
|
GH-138611 is a backport of this pull request to the 3.13 branch. |
|
GH-138612 is a backport of this pull request to the 3.14 branch. |
Member
|
For the sake of reducing the diff and correctly improve test coverage, I'm going to backport this. |
Contributor
Author
|
@serhiy-storchaka @picnixz Thank you for the review and guidance, I really appreciate it! |
Member
|
Thank you for the fix |
picnixz
pushed a commit
that referenced
this pull request
Sep 7, 2025
…H-138590) (#138611) gh-138584: Increase test coverage for `collections.UserList` (GH-138590) Some common tests in `test.list_tests.CommonTest` explicitly tested `list` instead of testing the underlying list-like type defined in `type2test`. --------- (cherry picked from commit d7b9ea5) Co-authored-by: dbXD320 <devanshbaghla320@gmail.com> Co-authored-by: Devansh Baghla <devanshbaghla34@gmail.com>
kumaraditya303
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2025
…ist` (pythonGH-138590) (python#138612) Co-authored-by: dbXD320 <devanshbaghla320@gmail.com> Co-authored-by: Devansh Baghla <devanshbaghla34@gmail.com>
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
…ython#138590) Some common tests in `test.list_tests.CommonTest` explicitly tested `list` instead of testing the underlying list-like type defined in `type2test`. --------- Co-authored-by: Devansh Baghla <devanshbaghla34@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates three tests in Lib/test/list_tests.py (CommonTest) to consistently use self.type2test instead of directly constructing a list (or []).
test_getitem_error
test_setitem_error
test_constructor_exception_handling
Previously, these tests only applied to the builtin list, and skipped other list-like classes (such as collections.UserList) that reuse CommonTest.
By switching to self.type2test, the tests now correctly apply to all list-like types under test, ensuring consistency across the test suite.
fixes #138584