gh-138250: load fast optimization should fall through to empty blocks#138249
Merged
DinoV merged 1 commit intopython:mainfrom Aug 29, 2025
Merged
gh-138250: load fast optimization should fall through to empty blocks#138249DinoV merged 1 commit intopython:mainfrom
DinoV merged 1 commit intopython:mainfrom
Conversation
mpage
approved these changes
Aug 29, 2025
Contributor
mpage
left a comment
There was a problem hiding this comment.
LGTM - fixes a bug and is much cleaner!
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
…blocks (python#138249) load fast optimization should fall through to empty blocks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In code like:
The compiler ends up producing an empty basic block. When the load fast optimization runs it sees that
term == NULLand doesn't fall through to the following block. The end result is that the compiler doesn't properly produce aLOAD_FAST_BORROWED_LOAD_FAST_BORROWEDopcode.The analysis should just use the
BB_HAS_FALLTHROUGHmacro instead of duplicating the logic.