gh-137681: Always initialize exception handler for new instruction#137655
Merged
DinoV merged 1 commit intopython:mainfrom Aug 13, 2025
Merged
gh-137681: Always initialize exception handler for new instruction#137655DinoV merged 1 commit intopython:mainfrom
DinoV merged 1 commit intopython:mainfrom
Conversation
9e390cb to
3a3a975
Compare
3a3a975 to
17de2a3
Compare
17de2a3 to
36a5650
Compare
Member
|
This change is fine, but I think basicblock_addop should get the target and except as args. There is a future bug here where setting the except matters, and someone will forget. |
Contributor
Author
Do you think we should back port this to 3.14? While the |
Member
|
If we don't have a bug in 3.14 I think we can leave it alone. We're not likely to insert new bytecode transformations there. |
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…ion (python#137655) Always initialize exception handler for new instruction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
basicblock_addopzero initializes some members but not all. If we remove some nops and then later re-add an instruction we can have previously initialized memory that can include an exception handler. If we compile something like: