Skip to content

gh-136958: fix unittest.TestCase.assertLogs() to properly handle logging.NOTSET level#137555

Open
alex-semenyuk wants to merge 2 commits intopython:mainfrom
alex-semenyuk:logging_notset
Open

gh-136958: fix unittest.TestCase.assertLogs() to properly handle logging.NOTSET level#137555
alex-semenyuk wants to merge 2 commits intopython:mainfrom
alex-semenyuk:logging_notset

Conversation

@alex-semenyuk
Copy link
Copy Markdown
Contributor

@alex-semenyuk alex-semenyuk commented Aug 8, 2025

Fix unittest.TestCase.assertLogs() to properly handle logging.NOTSET level

@alex-semenyuk alex-semenyuk marked this pull request as ready for review August 8, 2025 16:20
@alex-semenyuk
Copy link
Copy Markdown
Contributor Author

@vsajip friendly ping

@vsajip
Copy link
Copy Markdown
Member

vsajip commented Feb 17, 2026

I appreciate your input on this, but I'm not sure (as I said in the issue) that this is a logging issue - it's more related to unittest. So, I would expect a unittest maintainer to weigh in on whether this change is worth doing.

@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants