Skip to content

gh-135878: Fix crash in types.SimpleNamespace.__repr__ #135889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sobolevn merged 4 commits into from
Jun 24, 2025
Merged

gh-135878: Fix crash in types.SimpleNamespace.__repr__ #135889

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9a99c7
gh-135878: Fix crash in `types.SimpleNamespace.__repr__`
sobolevn Jun 24, 2025
eeb23d4
Update Misc/NEWS.d/next/Library/2025-06-24-14-43-24.gh-issue-135878.D…
sobolevn Jun 24, 2025
3e83d3a
Address review
sobolevn Jun 24, 2025
deb9223
Address review
sobolevn Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2025-06-24-14-43-24.gh-issue-135878.Db4roX.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fixes a crash of :class:`types.SimpleNamespace` on free-threading builds,
Comment thread
sobolevn marked this conversation as resolved.
Outdated
when several threads were calling its :meth:`~object.__repr__` method at the
same time.
5 changes: 2 additions & 3 deletions Objects/namespaceobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,7 @@ namespace_repr(PyObject *ns)
if (PyUnicode_Check(key) && PyUnicode_GET_LENGTH(key) > 0) {
PyObject *value, *item;

value = PyDict_GetItemWithError(d, key);
if (value != NULL) {
if (PyDict_GetItemRef(d, key, &value) == 1) {
Comment thread
sobolevn marked this conversation as resolved.
Outdated
item = PyUnicode_FromFormat("%U=%R", key, value);
Comment thread
sobolevn marked this conversation as resolved.
if (item == NULL) {
loop_error = 1;
Expand All @@ -135,7 +134,7 @@ namespace_repr(PyObject *ns)
Py_DECREF(item);
}
}
else if (PyErr_Occurred()) {
else {
Comment thread
sobolevn marked this conversation as resolved.
Outdated
loop_error = 1;
}
}
Expand Down
Loading