gh-78646: Add bytearray support to ipaddress#135811
Open
matan1008 wants to merge 1 commit intopython:mainfrom
Open
gh-78646: Add bytearray support to ipaddress#135811matan1008 wants to merge 1 commit intopython:mainfrom
matan1008 wants to merge 1 commit intopython:mainfrom
Conversation
Member
|
The original issue did not reach a consensus IMO and there was a suggestion:
|
cmaloney
reviewed
Jun 22, 2025
| if isinstance(address, bytes): | ||
| if isinstance(address, bytes) or isinstance(address, bytearray): | ||
| self._check_packed_address(address, 4) | ||
| self._ip = int.from_bytes(address) # big endian |
Contributor
There was a problem hiding this comment.
as a note, the int.from_bytes here will still memcpy to go from bytearray -> bytes internally (gh-132108). So this is just moving the need to copy at the moment, not eliminating entirely.
Member
|
I think that instead of overloading and slowing down main constructors, we should add more specific alternative constructors -- from bytes (accepts also anything that implements the buffer protocol), from integer, from string. |
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--135811.org.readthedocs.build/