Skip to content

gh-135709: Fix two compile warnings on WASM buildbot#135712

Merged
sobolevn merged 1 commit intopython:mainfrom
sobolevn:issue-135709
Jun 19, 2025
Merged

gh-135709: Fix two compile warnings on WASM buildbot#135712
sobolevn merged 1 commit intopython:mainfrom
sobolevn:issue-135709

Conversation

@sobolevn
Copy link
Copy Markdown
Member

@sobolevn sobolevn commented Jun 19, 2025 •
edited by bedevere-app Bot
Loading

@sobolevn sobolevn requested a review from vstinner June 19, 2025 12:57
@bedevere-app bedevere-app Bot mentioned this pull request Jun 19, 2025
Closed
@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Jun 19, 2025

!buildbot wasm

@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jun 19, 2025

🤖 New build scheduled with the buildbot fleet by @sobolevn for commit 5bd3fcc 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135712%2Fmerge

The command will test the builders whose names match following regular expression: wasm

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32-wasi PR
  • wasm32 WASI 8Core PR

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Jun 19, 2025

buildbot/wasm32 WASI 8Core PR
buildbot/wasm32-wasi Non-Debug PR

test_capi failed on both buildbots with:

thread 'main' has overflowed its stack
fatal runtime error: stack overflow

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Jun 19, 2025

fatal runtime error: stack overflow

I don't think that this error is related to this PR. I saw it on other PRs.

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Jun 19, 2025

I failed to reproduce the WASI issue locally. I built Python in release mode.

@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Jun 19, 2025

But, the warnings are gone: https://buildbot.python.org/#/builders/1373/builds/539/steps/11/logs/warnings__53_ :)

I've also seen them before. I can try fixing them here (but, I have no idea what causes it), or I can create a new issue. What would you prefer?

@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Jun 19, 2025

Thank you! I created: #135721

@sobolevn sobolevn merged commit 9c3c020 into python:main Jun 19, 2025
44 of 46 checks passed
@sobolevn sobolevn added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 19, 2025
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Jun 19, 2025

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Jun 19, 2025

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Jun 19, 2025

Sorry, @sobolevn, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 9c3c02019cf0bc7792bbdd3a314e45642178e3b5 3.13

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2025
@sobolevn @miss-islington
pythongh-135709: Fix two compile warnings on WASM buildbot (pythonGH-…
4dfda11 
…135712)

(cherry picked from commit 9c3c020)

Co-authored-by: sobolevn <mail@sobolevn.me>
@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Jun 19, 2025

Let's see if backports are possible.

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Jun 19, 2025

GH-135723 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 19, 2025
@sobolevn
Copy link
Copy Markdown
Member Author

sobolevn commented Jun 19, 2025

Yes, 3.13 is not affected. Only 3.14.

sobolevn added a commit that referenced this pull request Jun 19, 2025
@miss-islington @sobolevn
[3.14] gh-135709: Fix two compile warnings on WASM buildbot (GH-135712)…
8caf3fd 
… (#135723)

gh-135709: Fix two compile warnings on WASM buildbot (GH-135712)
(cherry picked from commit 9c3c020)

Co-authored-by: sobolevn <mail@sobolevn.me>
lkollar pushed a commit to lkollar/cpython that referenced this pull request Jun 19, 2025
@sobolevn @lkollar
pythongh-135709: Fix two compile warnings on WASM buildbot (python#13…
47ead3c 
…5712)
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sobolevn @Pranjal095
pythongh-135709: Fix two compile warnings on WASM buildbot (python#13…
a6561c5 
…5712)
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@sobolevn @taegyunkim
pythongh-135709: Fix two compile warnings on WASM buildbot (python#13…
b4cbc5a 
…5712)
@serhiy-storchaka
Copy link
Copy Markdown
Member

serhiy-storchaka commented Aug 14, 2025

Reminder about backporting. @sobolevn

@encukou
Copy link
Copy Markdown
Member

encukou commented Aug 15, 2025

3.13 is not affected.

@encukou encukou removed the needs backport to 3.13 bugs and security fixes label Aug 15, 2025
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@sobolevn @Agent-Hellboy
pythongh-135709: Fix two compile warnings on WASM buildbot (python#13…
4b03431 
…5712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

@sobolevn sobolevn

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @bedevere-bot @vstinner @serhiy-storchaka @encukou