Fix comments for heapq.siftup_max()#135359
Merged
kumaraditya303 merged 2 commits intopython:mainfrom Jul 3, 2025
Merged
Conversation
ZeroIntensity
added
skip issue
skip news
needs backport to 3.13
ZeroIntensity
approved these changes
Jun 11, 2025
Member
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
We generally don't accept changes to comments because they're considered cosmetic, but this one seems useful for maintenance purposes.
mpage
approved these changes
Jun 26, 2025
kumaraditya303
approved these changes
Jul 3, 2025
|
Thanks @yoney for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 3, 2025
(cherry picked from commit 8f8bdf2) Co-authored-by: Alper <alperyoney@fb.com> Co-authored-by: mpage <mpage@meta.com>
|
GH-136232 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 3, 2025
(cherry picked from commit 8f8bdf2) Co-authored-by: Alper <alperyoney@fb.com> Co-authored-by: mpage <mpage@meta.com>
|
GH-136233 is a backport of this pull request to the 3.13 branch. |
AndPuQing
pushed a commit
to AndPuQing/cpython
that referenced
this pull request
Jul 11, 2025
Co-authored-by: mpage <mpage@meta.com>
Pranjal095
pushed a commit
to Pranjal095/cpython
that referenced
this pull request
Jul 12, 2025
Co-authored-by: mpage <mpage@meta.com>
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Jul 13, 2025
Co-authored-by: mpage <mpage@meta.com>
taegyunkim
pushed a commit
to taegyunkim/cpython
that referenced
this pull request
Aug 4, 2025
Co-authored-by: mpage <mpage@meta.com>
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
Co-authored-by: mpage <mpage@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the comments for the heapq module. The
siftup()andsiftup_max()functions are very similar, with only 1 line of difference. However, thesiftup_max()still keeps the comments from thesiftup().Python version of
siftup_max()has the correct commentscpython/Lib/heapq.py
Line 308 in 0f866cb