Skip to content

gh-131712: Build _suggestions extension on Windows#131759

Merged
vstinner merged 1 commit intopython:mainfrom
vstinner:suggestions
Mar 27, 2025
Merged

gh-131712: Build _suggestions extension on Windows#131759
vstinner merged 1 commit intopython:mainfrom
vstinner:suggestions

Conversation

@vstinner
Copy link
Copy Markdown
Member

@vstinner vstinner commented Mar 26, 2025 •
edited by bedevere-app Bot
Loading

Add a test checking that the '_suggestions' extension is available.

@vstinner
pythongh-131712: Build _suggestions extension on Windows
87ce870 
Add a test checking that the '_suggestions' extension is available.
@vstinner vstinner requested a review from a team as a code owner March 26, 2025 11:00
@bedevere-app bedevere-app Bot mentioned this pull request Mar 26, 2025
Closed
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Mar 26, 2025

cc @devdanzin

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Mar 26, 2025

The code is already built:

$ grep _suggestions PCbuild/pythoncore.vcxproj
    <ClCompile Include="..\Modules\_suggestions.c" />

This PR only makes the extension available in Python.

@zooba
Copy link
Copy Markdown
Member

zooba commented Mar 26, 2025

If we've had any releases with this broken, we should probably add a NEWS entry to mention that it's been fixed (describing the user-visible impact, rather than the module itself).

@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Mar 26, 2025

If we've had any releases with this broken, we should probably add a NEWS entry to mention that it's been fixed (describing the user-visible impact, rather than the module itself).

I added "skip news" label since there is no impact on users, since there is a fallback implementation in Python: #131712 (comment)

@vstinner vstinner merged commit 9ef9d68 into python:main Mar 27, 2025
49 checks passed
@vstinner vstinner deleted the suggestions branch March 27, 2025 08:53
@vstinner
Copy link
Copy Markdown
Member Author

vstinner commented Mar 27, 2025

Merged, thanks for the review @zooba.

@vstinner vstinner added the needs backport to 3.13 bugs and security fixes label Mar 27, 2025
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Mar 27, 2025

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 27, 2025
@vstinner @miss-islington
pythongh-131712: Build _suggestions extension on Windows (pythonGH-13…
2a7bb70 
…1759)

Add a test checking that the '_suggestions' extension is available.
(cherry picked from commit 9ef9d68)

Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Mar 27, 2025

GH-131790 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Mar 27, 2025
vstinner added a commit that referenced this pull request Mar 27, 2025
@miss-islington @vstinner
[3.13] gh-131712: Build _suggestions extension on Windows (GH-131759) (…
5c0be8c 
…#131790)

gh-131712: Build _suggestions extension on Windows (GH-131759)

Add a test checking that the '_suggestions' extension is available.
(cherry picked from commit 9ef9d68)

Co-authored-by: Victor Stinner <vstinner@python.org>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
@vstinner @diegorusso
pythongh-131712: Build _suggestions extension on Windows (python#131759)
0d4b376 
Add a test checking that the '_suggestions' extension is available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vstinner @zooba