Skip to content

gh-131677: Fix flaky test_lru_cache_threaded3#131679

Merged
colesbury merged 1 commit intopython:mainfrom
colesbury:gh-131677-flaky-test_lru_cache_threaded3
Mar 24, 2025
Merged

gh-131677: Fix flaky test_lru_cache_threaded3#131679
colesbury merged 1 commit intopython:mainfrom
colesbury:gh-131677-flaky-test_lru_cache_threaded3

Conversation

@colesbury
Copy link
Copy Markdown
Contributor

@colesbury colesbury commented Mar 24, 2025 •
edited by bedevere-app Bot
Loading

The call to with self.subTest(...) was not thread-safe.

@colesbury
pythongh-131677: Fix flaky test_lru_cache_threaded3
238f68d 
The call to `with self.subTest(...)` was not thread-safe.
@colesbury colesbury requested a review from vstinner March 24, 2025 16:06
@colesbury colesbury requested a review from rhettinger as a code owner March 24, 2025 16:06
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Mar 24, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 24, 2025
Closed
@rhettinger rhettinger requested review from serhiy-storchaka and removed request for rhettinger March 24, 2025 16:53
@rhettinger
Copy link
Copy Markdown
Contributor

rhettinger commented Mar 24, 2025

@serhiy-storchaka This is your code. Do you want to take a look?

@colesbury Can subTest be made thread-safe?

vstinner
vstinner approved these changes Mar 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colesbury
Copy link
Copy Markdown
Contributor Author

colesbury commented Mar 24, 2025

Can subTest be made thread-safe?

I think practically you'd have to get rid of self._subtest in unittest.TestCase and I'd generally be a bit concerned about that sort of change for something as widely used as unittest

serhiy-storchaka
serhiy-storchaka approved these changes Mar 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Surprised that it did not fail more often. 🤔

@rhettinger
Copy link
Copy Markdown
Contributor

rhettinger commented Mar 24, 2025

As you fix these, perhaps keep a list of tools that are intrinsically single-threaded. Such as list might be useful for linters and it might make a good FAQ entry.

@colesbury colesbury merged commit a123245 into python:main Mar 24, 2025
48 checks passed
@colesbury colesbury deleted the gh-131677-flaky-test_lru_cache_threaded3 branch March 24, 2025 20:41
@colesbury colesbury added the needs backport to 3.13 bugs and security fixes label Mar 24, 2025
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Mar 24, 2025

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 24, 2025
@colesbury @miss-islington
pythongh-131677: Fix flaky test_lru_cache_threaded3 (pythongh-131679)
5f337d2 
The call to `with self.subTest(...)` was not thread-safe.
(cherry picked from commit a123245)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Mar 24, 2025

GH-131692 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Mar 24, 2025
@colesbury colesbury added the needs backport to 3.12 only security fixes label Mar 24, 2025
@miss-islington-app
Copy link
Copy Markdown

miss-islington-app Bot commented Mar 24, 2025

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 24, 2025
@colesbury @miss-islington
pythongh-131677: Fix flaky test_lru_cache_threaded3 (pythongh-131679)
e8e5b5d 
The call to `with self.subTest(...)` was not thread-safe.
(cherry picked from commit a123245)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Mar 24, 2025

GH-131693 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 24, 2025
colesbury added a commit that referenced this pull request Mar 24, 2025
@miss-islington @colesbury
[3.12] gh-131677: Fix flaky test_lru_cache_threaded3 (gh-131679) (gh-…
e78280d 
…131693)

The call to `with self.subTest(...)` was not thread-safe.
(cherry picked from commit a123245)

Co-authored-by: Sam Gross <colesbury@gmail.com>
colesbury added a commit that referenced this pull request Mar 24, 2025
@miss-islington @colesbury
[3.13] gh-131677: Fix flaky test_lru_cache_threaded3 (gh-131679) (gh-…
c22eef4 
…131692)

The call to `with self.subTest(...)` was not thread-safe.
(cherry picked from commit a123245)

Co-authored-by: Sam Gross <colesbury@gmail.com>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
@colesbury @diegorusso
pythongh-131677: Fix flaky test_lru_cache_threaded3 (pythongh-131679)
2ba3b0c 
The call to `with self.subTest(...)` was not thread-safe.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@rhettinger rhettinger rhettinger approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@colesbury @rhettinger @vstinner @serhiy-storchaka