gh-131418: remove unused legacy typedefs in {md5,sha1}module.c#131420
Merged
picnixz merged 1 commit intopython:mainfrom Mar 23, 2025
Merged
gh-131418: remove unused legacy typedefs in {md5,sha1}module.c#131420picnixz merged 1 commit intopython:mainfrom
{md5,sha1}module.c#131420picnixz merged 1 commit intopython:mainfrom
Conversation
eendebakpt
approved these changes
Mar 18, 2025
Member
Author
|
I forgot to merge this one this morning. I'm leaving for a few days so I'll merge it on Sunday (with a commit message indicating which |
vstinner
approved these changes
Mar 20, 2025
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. If the code still builds after this change, the code was dead code :-)
Member
Author
|
I'll backport them to 3.12 and 3.13, as HACL* MD5 and HACL* SHA-1 are already present. It doesn't hurt (it's also good to reduce the number of lines in the file) |
picnixz
added
needs backport to 3.12
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 23, 2025
pythonGH-131420) - Remove legacy typedefs `MD5_INT32` and `MD5_INT64` in `Modules/md5module.c` - Remove legacy typedefs `SHA1_INT32` and `SHA1_INT64` in `Modules/sha1module.c`. Those legacy typedefs were used to detect whether the host platform could correctly implement MD5 and SHA-1, but this is no longer needed as we now fallback to HACL* implementations. (cherry picked from commit a9a399f) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-131619 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 23, 2025
pythonGH-131420) - Remove legacy typedefs `MD5_INT32` and `MD5_INT64` in `Modules/md5module.c` - Remove legacy typedefs `SHA1_INT32` and `SHA1_INT64` in `Modules/sha1module.c`. Those legacy typedefs were used to detect whether the host platform could correctly implement MD5 and SHA-1, but this is no longer needed as we now fallback to HACL* implementations. (cherry picked from commit a9a399f) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
|
GH-131620 is a backport of this pull request to the 3.13 branch. |
picnixz
added a commit
that referenced
this pull request
Mar 23, 2025
…c` (GH-131420) (#131619) gh-131418: remove unused legacy typedefs in `{md5,sha1}module.c` (GH-131420) - Remove legacy typedefs `MD5_INT32` and `MD5_INT64` in `Modules/md5module.c` - Remove legacy typedefs `SHA1_INT32` and `SHA1_INT64` in `Modules/sha1module.c`. Those legacy typedefs were used to detect whether the host platform could correctly implement MD5 and SHA-1, but this is no longer needed as we now fallback to HACL* implementations. (cherry picked from commit a9a399f) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
picnixz
added a commit
that referenced
this pull request
Mar 23, 2025
…c` (GH-131420) (#131620) gh-131418: remove unused legacy typedefs in `{md5,sha1}module.c` (GH-131420) - Remove legacy typedefs `MD5_INT32` and `MD5_INT64` in `Modules/md5module.c` - Remove legacy typedefs `SHA1_INT32` and `SHA1_INT64` in `Modules/sha1module.c`. Those legacy typedefs were used to detect whether the host platform could correctly implement MD5 and SHA-1, but this is no longer needed as we now fallback to HACL* implementations. (cherry picked from commit a9a399f) Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
md5module.candsha1module.c#131418