gh-130914: Make graphlib.TopologicalSorter.prepare() idempotent

Doc/whatsnew/3.14.rst

@@ -465,6 +465,15 @@ getopt
 * Add support for returning intermixed options and non-option arguments in order.
   (Contributed by Serhiy Storchaka in :gh:`126390`.)
 
+
+graphlib
+--------
+
+* Allow :meth:`graphlib.TopologicalSorter.prepare` to be called more than once
+  as long as sorting has not started.
+  (Contributed by Daniel Pope in :gh:`130914`)
+
+
 http
 ----
 

Lib/graphlib.py

@@ -92,7 +92,9 @@ def prepare(self):
         therefore no more nodes can be added using "add".
         """
         if self._ready_nodes is not None:
-            raise ValueError("cannot prepare() more than once")
+            if self._npassedout > 0:
+                raise ValueError("cannot prepare() after starting sort")
+            return
 
         self._ready_nodes = [
             i.node for i in self._node2info.values() if i.npredecessors == 0

Lib/test/test_graphlib.py

@@ -140,7 +140,13 @@ def test_calls_before_prepare(self):
     def test_prepare_multiple_times(self):
         ts = graphlib.TopologicalSorter()
         ts.prepare()
-        with self.assertRaisesRegex(ValueError, r"cannot prepare\(\) more than once"):
+        ts.prepare()
+
+    def test_prepare_after_pass_out(self):
+        ts = graphlib.TopologicalSorter({'a': 'bc'})
+        ts.prepare()
+        self.assertEqual(set(ts.get_ready()), {'b', 'c'})
+        with self.assertRaisesRegex(ValueError, r"cannot prepare\(\) after starting sort"):
             ts.prepare()
 
     def test_invalid_nodes_in_done(self):

Misc/NEWS.d/next/Library/2025-03-16-08-00-29.gh-issue-130914.6z883_.rst

@@ -0,0 +1,3 @@
+Allow :meth:`graphlib.TopologicalSorter.prepare` to be called more than once
+as long as sorting has not started.
+Patch by Daniel Pope.