gh-127667: refactor and improve _hashopenssl.c error branches#131145
Merged
picnixz merged 7 commits intopython:mainfrom Mar 17, 2025
Merged
gh-127667: refactor and improve _hashopenssl.c error branches#131145picnixz merged 7 commits intopython:mainfrom
_hashopenssl.c error branches#131145picnixz merged 7 commits intopython:mainfrom
Conversation
picnixz
added
needs backport to 3.12
Member
Author
|
I'm backporting this because future changes will likely have conflicts since error branches would be handled differently. |
gpshead
approved these changes
Mar 16, 2025
Member
gpshead
left a comment
gpshead
left a comment
There was a problem hiding this comment.
thanks, nice refactoring for better maintainability.
|
Thanks @picnixz for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
|
Sorry, @picnixz, I could not cleanly backport this to |
|
Sorry, @picnixz, I could not cleanly backport this to |
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Mar 17, 2025
…python#131145) Refactor `_setException()` into different helpers that can be used separately: - set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code. - raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message. - notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message.
|
GH-131347 is a backport of this pull request to the 3.13 branch. |
picnixz
added a commit
to picnixz/cpython
that referenced
this pull request
Mar 17, 2025
…python#131145) Refactor `_setException()` into different helpers that can be used separately: - set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code. - raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message. - notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message. # Conflicts: # Modules/_hashopenssl.c
|
GH-131348 is a backport of this pull request to the 3.12 branch. |
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
…python#131145) Refactor `_setException()` into different helpers that can be used separately: - set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code. - raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message. - notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message.
picnixz
added a commit
that referenced
this pull request
Mar 18, 2025
#131145) (#131348) gh-127667: refactor and improve `_hashopenssl.c` error branches (#131145) Refactor `_setException()` into different helpers that can be used separately: - set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code. - raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message. - notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message. (cherry-picked from commit ac50ece).
picnixz
added a commit
that referenced
this pull request
Mar 18, 2025
#131145) (#131347) gh-127667: refactor and improve `_hashopenssl.c` error branches (#131145) Refactor `_setException()` into different helpers that can be used separately: - set_ssl_exception_from_errcode(): set an exception from an explicit SSL error code. - raise_ssl_error(): set an exception from the last SSL error code or use a user-defined message. - notify_ssl_error_occurred(): same as raise_ssl_error() but with a generic default message. (cherry-picked from commit ac50ece).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we had a single
_setException()helper and most of the time, we always did the same thing. Sometimes it's also not necessary to actually create ava_list.hashlib#127667