Skip to content

gh-131002: clarify how to enforce sqlite3 column types for generated fields#131006

Merged
erlend-aasland merged 7 commits intopython:mainfrom
erlend-aasland:sqlite/doc-parse-types-for-generated-fields
Mar 17, 2025
Merged

gh-131002: clarify how to enforce sqlite3 column types for generated fields#131006
erlend-aasland merged 7 commits intopython:mainfrom
erlend-aasland:sqlite/doc-parse-types-for-generated-fields

Conversation

@erlend-aasland
Copy link
Copy Markdown
Contributor

@erlend-aasland erlend-aasland commented Mar 9, 2025 •
edited
Loading

  • reorder PARSE_DECLTYPES and PARSE_COLNAMES doc entries so PARSE_DECLTYPES comes first, as its example introduces the example SQL table
  • clarify how to properly quote column names
  • help the reader to use converters for generated fields

📚 Documentation preview 📚: https://cpython-previews--131006.org.readthedocs.build/

@erlend-aasland erlend-aasland added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels Mar 9, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Mar 9, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 9, 2025
Closed
@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Mar 9, 2025

WDYT, @DLu and @picnixz?

erlend-aasland
erlend-aasland commented Mar 9, 2025
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
erlend-aasland
erlend-aasland commented Mar 9, 2025
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
DLu
DLu approved these changes Mar 9, 2025
View reviewed changes
Copy link
Copy Markdown

@DLu DLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@picnixz picnixz self-requested a review March 12, 2025 14:43
picnixz
picnixz reviewed Mar 12, 2025
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
erlend-aasland and others added 3 commits March 13, 2025 20:32
@erlend-aasland @picnixz
Update Doc/library/sqlite3.rst
9ed49e4 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@erlend-aasland
Pull in main
e94726a
@erlend-aasland
Use '.. note::'
5cf5da0
erlend-aasland
erlend-aasland commented Mar 17, 2025
View reviewed changes
Comment thread Doc/library/sqlite3.rst Outdated
@erlend-aasland erlend-aasland enabled auto-merge (squash) March 17, 2025 22:21
@erlend-aasland
Copy link
Copy Markdown
Contributor Author

erlend-aasland commented Mar 17, 2025

Thanks for the reviews!

@erlend-aasland erlend-aasland linked an issue Mar 17, 2025 that may be closed by this pull request
[sqlite3] Converter Not Called with Aggregate Functions #131002
Closed
@erlend-aasland erlend-aasland merged commit f48887f into python:main Mar 17, 2025
@erlend-aasland erlend-aasland deleted the sqlite/doc-parse-types-for-generated-fields branch March 17, 2025 22:26
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Mar 17, 2025
@miss-islington-app

This comment was marked as outdated.

Sign in to view
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 17, 2025
@erlend-aasland @miss-islington
pythongh-131002: clarify how to enforce sqlite3 column types for gene…
9ad9bd9 
…rated fields (pythonGH-131006)

(cherry picked from commit f48887f)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Mar 17, 2025

GH-131385 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Mar 17, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 17, 2025
@erlend-aasland @miss-islington
pythongh-131002: clarify how to enforce sqlite3 column types for gene…
34b682d 
…rated fields (pythonGH-131006)

(cherry picked from commit f48887f)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Mar 17, 2025

GH-131386 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 17, 2025
erlend-aasland added a commit that referenced this pull request Mar 18, 2025
@miss-islington @erlend-aasland
[3.13] gh-131002: clarify how to enforce sqlite3 column types for gen…
e425b07 
…erated fields (GH-131006) (#131385)

(cherry picked from commit f48887f)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
erlend-aasland added a commit that referenced this pull request Mar 18, 2025
@miss-islington @erlend-aasland
[3.12] gh-131002: clarify how to enforce sqlite3 column types for gen…
9d23a6d 
…erated fields (GH-131006) (#131386)

(cherry picked from commit f48887f)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
colesbury pushed a commit to colesbury/cpython that referenced this pull request Mar 20, 2025
@erlend-aasland @colesbury
pythongh-131002: clarify how to enforce sqlite3 column types for gene…
20bdad2 
…rated fields (python#131006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

+1 more reviewer

@DLu DLu DLu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[sqlite3] Converter Not Called with Aggregate Functions

3 participants

@erlend-aasland @DLu @picnixz