Skip to content

gh-109861: Fix a doctest in Lib/_pydecimal.py which was failing when running its doctests directly.#125479

Open
mbyrnepr2 wants to merge 3 commits intopython:mainfrom
mbyrnepr2:issue-109861-fix-doctest
Open

gh-109861: Fix a doctest in Lib/_pydecimal.py which was failing when running its doctests directly.#125479
mbyrnepr2 wants to merge 3 commits intopython:mainfrom
mbyrnepr2:issue-109861-fix-doctest

Conversation

@mbyrnepr2
Copy link
Copy Markdown
Contributor

gh-109861: Fix a doctest in Lib/_pydecimal.py which was failing when run directly on the module via the command:
./python.exe -m doctest Lib/_pydecimal.py.

directly on the module via the command:
``./python.exe -m doctest Lib/_pydecimal.py``.

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Copy link
Copy Markdown
Member

@skirpichev skirpichev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should stick with your solution for _pydecimal.py. It's more local.

require the ``InvalidOperation`` trap to be ``False``.
@skirpichev
Copy link
Copy Markdown
Member

CC @picnixz

Copy link
Copy Markdown
Member

@tim-one tim-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@skirpichev skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jan 28, 2026
@github-actions
Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting merge needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants