gh-119494 Fix error messages for deleting/setting type attributes#119495
Merged
iritkatriel merged 8 commits intopython:mainfrom Sep 18, 2025
Merged
gh-119494 Fix error messages for deleting/setting type attributes#119495iritkatriel merged 8 commits intopython:mainfrom
iritkatriel merged 8 commits intopython:mainfrom
Conversation
Deleting is always an error and doesn't depend on mutability. Setting is tested after deleting.
da-woods
commented
May 24, 2024
Member
|
There's some failing tests in |
Contributor
Author
|
@JelleZijlstra done |
iritkatriel
reviewed
Sep 18, 2025
iritkatriel
approved these changes
Sep 18, 2025
Member
|
Linter is complaining about the news file. |
Contributor
Author
|
I'll fix it later today - I can see what's wrong but I don't think I can rename the file from my phone |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting is always an error and doesn't depend on mutability.
Setting is tested after deleting.
__name__#119494