Skip to content

gh-119494 Fix error messages for deleting/setting type attributes#119495

Merged
iritkatriel merged 8 commits intopython:mainfrom
da-woods:patch-2
Sep 18, 2025
Merged

gh-119494 Fix error messages for deleting/setting type attributes#119495
iritkatriel merged 8 commits intopython:mainfrom
da-woods:patch-2

Conversation

@da-woods
Copy link
Copy Markdown
Contributor

@da-woods da-woods commented May 24, 2024

Deleting is always an error and doesn't depend on mutability.

Setting is tested after deleting.

Deleting is always an error and doesn't depend on mutability.

Setting is tested after deleting.
Comment thread Objects/typeobject.c Outdated
@JelleZijlstra
Copy link
Copy Markdown
Member

There's some failing tests in test_descr, could you update the error message there?

@da-woods
Copy link
Copy Markdown
Contributor Author

@JelleZijlstra done

Comment thread Objects/typeobject.c
@iritkatriel
Copy link
Copy Markdown
Member

Linter is complaining about the news file.

@da-woods
Copy link
Copy Markdown
Contributor Author

I'll fix it later today - I can see what's wrong but I don't think I can rename the file from my phone

@iritkatriel iritkatriel merged commit ac5c5d4 into python:main Sep 18, 2025
45 checks passed
@bedevere-bot
Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Windows PGO NoGIL 3.x (tier-1) has failed when building commit ac5c5d4.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1622/builds/2696) and take a look at the build logs.
  4. Check if the failure is related to this commit (ac5c5d4) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1622/builds/2696

Failed tests:

  • test_tracemalloc
  • test.test_multiprocessing_spawn.test_misc

Failed subtests:

  • test_wait_integer - test.test_multiprocessing_spawn.test_misc.TestWait.test_wait_integer

Summary of the results of the build (if available):

==

Click to see traceback logs
Traceback (most recent call last):
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\contextlib.py", line 85, in inner
    return func(*args, **kwds)
  File "C:\Users\Administrator\buildarea\3.x.itamaro-win64-srv-22-aws.nogil.pgo\build\Lib\test\_test_multiprocessing.py", line 5612, in test_wait_integer
    self.assertLess(delta, expected + 2)
    ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
AssertionError: 7.376583200064488 not less than 5

@da-woods da-woods deleted the patch-2 branch September 19, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants